[Buttons] Add a boolean for when observing cornerRadius so that we wo…

…n't try to add 2 observers or remove a non-existent observer PiperOrigin-RevId: 314722144
material-components · Jun 4, 2020 · 3d5c27f · 3d5c27f
1 parent 52ee290
commit 3d5c27f
Showing 1 changed file with 19 additions and 8 deletions.
diff --git a/components/Buttons/src/MDCButton.m b/components/Buttons/src/MDCButton.m
@@ -109,6 +109,7 @@ @interface MDCButton () {
   NSString *_accessibilityLabelExplicitValue;
 
   BOOL _mdc_adjustsFontForContentSizeCategory;
+  BOOL _cornerRadiusObserverAdded;
 }
 @property(nonatomic, strong, readonly, nonnull) MDCStatefulRippleView *rippleView;
 @property(nonatomic, strong) MDCInkView *inkView;
@@ -269,7 +270,7 @@ - (void)commonMDCButtonInit {
 - (void)dealloc {
   [self removeTarget:self action:NULL forControlEvents:UIControlEventAllEvents];
 
-  if (!UIEdgeInsetsEqualToEdgeInsets(self.visibleAreaInsets, UIEdgeInsetsZero)) {
+  if (_cornerRadiusObserverAdded) {
     [self.layer removeObserver:self
                     forKeyPath:NSStringFromSelector(@selector(cornerRadius))
                        context:kKVOContextCornerRadius];
@@ -1048,21 +1049,31 @@ - (void)setUnderlyingColor:(UIColor *)underlyingColor {
 #pragma mark - Visible area
 
 - (void)setVisibleAreaInsets:(UIEdgeInsets)visibleAreaInsets {
+  if (UIEdgeInsetsEqualToEdgeInsets(visibleAreaInsets, _visibleAreaInsets)) {
+    return;
+  }
+
   _visibleAreaInsets = visibleAreaInsets;
 
   if (UIEdgeInsetsEqualToEdgeInsets(visibleAreaInsets, UIEdgeInsetsZero)) {
     self.shapeGenerator = nil;
 
-    [self.layer removeObserver:self
-                    forKeyPath:NSStringFromSelector(@selector(cornerRadius))
-                       context:kKVOContextCornerRadius];
+    if (_cornerRadiusObserverAdded) {
+      [self.layer removeObserver:self
+                      forKeyPath:NSStringFromSelector(@selector(cornerRadius))
+                         context:kKVOContextCornerRadius];
+      _cornerRadiusObserverAdded = NO;
+    }
   } else {
     self.shapeGenerator = [self generateShapeWithCornerRadius:self.layer.cornerRadius];
 
-    [self.layer addObserver:self
-                 forKeyPath:NSStringFromSelector(@selector(cornerRadius))
-                    options:NSKeyValueObservingOptionNew
-                    context:kKVOContextCornerRadius];
+    if (!_cornerRadiusObserverAdded) {
+      [self.layer addObserver:self
+                   forKeyPath:NSStringFromSelector(@selector(cornerRadius))
+                      options:NSKeyValueObservingOptionNew
+                      context:kKVOContextCornerRadius];
+      _cornerRadiusObserverAdded = YES;
+    }
   }
 }