Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): Fix incorrect ripple effect on filter chip #4565

Merged
merged 4 commits into from Apr 4, 2019
Merged

fix(chips): Fix incorrect ripple effect on filter chip #4565

merged 4 commits into from Apr 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2019

Fixes #2812

@ghost ghost changed the title fix(chips): Combine ClientRect properties fix(chips): adapter.getDimensions doesn't combine ClientRect's properties Apr 3, 2019
@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #4565 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4565     +/-   ##
=========================================
+ Coverage   99.02%   99.33%   +0.3%     
=========================================
  Files         130      130             
  Lines        6279     6276      -3     
  Branches      820      820             
=========================================
+ Hits         6218     6234     +16     
+ Misses         60       41     -19     
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-chips/chip/foundation.ts 100% <100%> (ø) ⬆️
packages/mdc-checkbox/component.ts 96.8% <0%> (+1.06%) ⬆️
packages/mdc-tab/component.ts 98.33% <0%> (+3.33%) ⬆️
packages/mdc-base/component.ts 100% <0%> (+3.57%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.84%) ⬆️
packages/mdc-ripple/util.ts 97.95% <0%> (+4.08%) ⬆️
packages/mdc-auto-init/index.ts 100% <0%> (+4.54%) ⬆️
packages/mdc-tabs/tab/component.ts 100% <0%> (+5%) ⬆️
packages/mdc-switch/component.ts 98.21% <0%> (+7.14%) ⬆️
packages/mdc-radio/component.ts 95.65% <0%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968a054...06db0dc. Read the comment docs.

packages/mdc-chips/chip/foundation.ts Outdated Show resolved Hide resolved
packages/mdc-chips/chip/foundation.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abhiomkar abhiomkar changed the title fix(chips): adapter.getDimensions doesn't combine ClientRect's properties fix(chips): Fix incorrect ripple effect on filter chip Apr 4, 2019
@abhiomkar abhiomkar merged commit 975bae2 into material-components:master Apr 4, 2019
abhiomkar pushed a commit that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants