Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gatsby config filename #382

Merged
merged 2 commits into from
Feb 3, 2019

Conversation

eli8levit
Copy link
Contributor

In #188 PR there was added an icon to the Gatsby config file. But according to the Gatsby docs the filename should be gatsby-config.js instead of gatsby.config.js.

In addition, I've added gatsby-node.js filename to the same icon according to this Gatsby guide.

Add gatsby-node fileName to existing gatsby icon
@eli8levit eli8levit changed the title Fix Gatsby config fileName Fix Gatsby config filename Jan 27, 2019
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please insert all file names into one array and leave the old gatsby.config.js in it:

{ name: 'gatsby', fileNames: ['gatsby.config.js', 'gatsby-config.js', 'gatsby-node.js'] }

@eli8levit
Copy link
Contributor Author

Sure!

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@PKief PKief merged commit 248a102 into material-extensions:master Feb 3, 2019
@eli8levit
Copy link
Contributor Author

@PKief Thank you! I'm using your theme for a long time and it's awesome 👏

@PKief
Copy link
Member

PKief commented Feb 3, 2019

@JediYozh I'm glad you like it, thank you! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants