-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for grayscale icons #387
Conversation
Hey @cezarsa, this is one of the best PRs I've ever received 😄 I also like the idea of toggling the greyscale filter on and off. It would be interesting for me if you could give me some feedback if we should make it "true/false" as in this PR or provide an option (same as for the opacity) to customize the saturation by value:
Do you think it makes sense to customize the saturation? |
This feature looks great! I think I’ll implement it as well :) |
@PKief Thank you. :) I considered exposing the saturation directly but in the end I thought having only a grayscale config would be more straightforward for end users. However, I do like the flexibility of tweaking with different saturations. I think a compromise may be reached by having a single configuration option
|
@cezarsa Yes, this sounds really good 👍 |
It's done, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, it looks very good and has a very high quality.
Hi, I'm not a big fan of colored icons as I think they draw too much attention, however, I do like having different symbols for each file type.
Inspired by the awesome hack used to change the icons opacity I added a new command and configuration to allow switching all icons to grayscale. This is done by adding an SVG filter to each icon file changing its saturation to 0.
Here is an example of how it looks: (I loved it!)