-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernization PR #369
Merged
Merged
Modernization PR #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Elements" and "Forms"
for more information, see https://pre-commit.ci
This PR will also:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I intend to merge this PR once tests pass (which I believe are just Python 3.9 related) since the PR is otherwise complete, and should not contain any breaking changes. I've updated the documentation. I expect an additional "Modernization" PR to follow at a later date. |
The update to 3.10 is mainly to allow for use of 3.10 features like type hints and to simplify development. If support for older Python versions is required, it should be possible to relax this requirement with minimal effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address some of the items in #265. In brief, several choices were made early on in Crystal Toolkit development due to the limitations of Dash v1. Some of these choices can now be re-thought due to features now available in Dash 2.
In addition, several aspects of Crystal Toolkit are either poorly documented or incomplete, and I would like to make sure these are polished.
So far, this PR includes:
CrystalToolkitPlugin
to replace the oldregister_crystal_toolkit()
method.Notifying the MP infra team (@tschaume, @yang-ruoxi, @munrojm, @janosh, @tsmathis). I'm making every effort to make sure no backwards incompatible changes are introduced. It's possible some backwards incompatible changes will be required, but if so I'll try and make these minimal and make sure that a migration path is easy and documented.