Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Python version to 3.9 #455

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Bump minimum Python version to 3.9 #455

merged 6 commits into from
Oct 17, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 15, 2023

We could hold off on this. Only reason for doing this is to stay in sync with numpy and the rest of the MP ecosystem (e.g. materialsproject/pymatgen#3283).

@janosh janosh added breaking Breaking changes pkg Package health and distribution related stuff labels Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #455 (1f0a570) into main (e062ecc) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #455   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1521      1523    +2     
  Branches       419       419           
=========================================
+ Hits          1521      1523    +2     
Files Coverage Δ
src/jobflow/core/flow.py 100.00% <100.00%> (ø)
src/jobflow/core/job.py 100.00% <ø> (ø)
src/jobflow/core/reference.py 100.00% <100.00%> (ø)
src/jobflow/core/store.py 100.00% <ø> (ø)
src/jobflow/managers/fireworks.py 100.00% <ø> (ø)
src/jobflow/schemas/job_output_schema.py 100.00% <100.00%> (ø)
src/jobflow/utils/find.py 100.00% <ø> (ø)

@janosh janosh merged commit 231690c into main Oct 17, 2023
1 check passed
@janosh janosh deleted the bump-min-py-39 branch October 17, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes house-keeping pkg Package health and distribution related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants