-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow different UID types #529
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 99.86% 99.42% -0.45%
==========================================
Files 20 21 +1
Lines 1514 1556 +42
Branches 417 422 +5
==========================================
+ Hits 1512 1547 +35
- Misses 2 9 +7
|
Thanks for implementing the change and making uuid4 the default. |
Yeah that makes sense. |
BTW does anyone know what the |
Thanks @jmmshn. Is it possible to make The |
Thanks @jmmshn |
BTW, can we get a release with this, then I can finish the atomate2 PR. |
Done ( |
Only allow UUIDs that can be sorted in time
Partially addresses:
#519
*uuid
->*uid
UID_TYPE
uuid1
andulid
viapython-ulid