Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.11 support + expand python versions tested in CI #737

Merged
merged 8 commits into from
Jun 8, 2023

Conversation

rkingsbury
Copy link
Collaborator

@rkingsbury rkingsbury commented Oct 25, 2022

  • Add python 3.10 and 3.11 to CI test suite
  • bump numpy to 1.23 to enable python 3.11 support
  • bump montdb to 2.5.0 to enable python 3.11 support

Note: Per NEP 29, we are past the Python 3.7 support window, but since we are still supporting python 3.7 (it's not causing any problems); we should leave it in the CI test matrix.

@rkingsbury
Copy link
Collaborator Author

Something going on with 3.10 related to actions/setup-python#160. Will investigate later

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Patch and project coverage have no change.

Comparison is base (3176c62) 88.12% compared to head (de557d1) 88.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #737   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          44       44           
  Lines        3562     3563    +1     
=======================================
+ Hits         3139     3140    +1     
  Misses        423      423           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rkingsbury
Copy link
Collaborator Author

Looks like montydb is a blocker for python 3.11 support at the moment.

@rkingsbury rkingsbury changed the title Misc. CI and linting updates Expand CI test coverage; drop python 3.7, add python 3.11 support Jun 8, 2023
@rkingsbury rkingsbury changed the title Expand CI test coverage; drop python 3.7, add python 3.11 support python 3.11 support + expand python versions tested in CI Jun 8, 2023
@rkingsbury rkingsbury added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Jun 8, 2023
@rkingsbury rkingsbury merged commit 0e05844 into materialsproject:main Jun 8, 2023
@rkingsbury rkingsbury deleted the ci_updates branch June 8, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant