Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit store close to resources #814

Merged
merged 13 commits into from
Jul 6, 2023
Merged

Add explicit store close to resources #814

merged 13 commits into from
Jul 6, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 6, 2023

This PR ensures the store connection are explicitly closed in reach resource class after a query is executed.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 92.30% and no project coverage change.

Comparison is base (e2daca3) 88.12% compared to head (36434d7) 88.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          44       44           
  Lines        3620     3630   +10     
=======================================
+ Hits         3190     3199    +9     
- Misses        430      431    +1     
Impacted Files Coverage Δ
src/maggma/api/API.py 81.81% <ø> (-0.41%) ⬇️
src/maggma/api/query_operator/dynamic.py 94.28% <ø> (ø)
src/maggma/api/query_operator/pagination.py 96.00% <ø> (ø)
src/maggma/api/query_operator/submission.py 95.45% <ø> (ø)
src/maggma/api/resource/aggregation.py 89.58% <ø> (ø)
src/maggma/api/resource/core.py 80.00% <ø> (ø)
src/maggma/api/resource/s3_url.py 58.00% <0.00%> (-1.19%) ⬇️
src/maggma/api/resource/utils.py 80.76% <0.00%> (ø)
src/maggma/builders/group_builder.py 84.31% <ø> (ø)
src/maggma/cli/source_loader.py 70.11% <0.00%> (ø)
... and 16 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 4675761 into main Jul 6, 2023
@munrojm munrojm deleted the bugfix/store_close branch July 6, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant