Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kumagai Correction #196

Merged
merged 11 commits into from
May 21, 2024
Merged

Kumagai Correction #196

merged 11 commits into from
May 21, 2024

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented May 21, 2024

Kumagai Correction

  • Added pydefect back as a dep now that the numpy conflict is gone
  • Added tests back

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.95%. Comparing base (8a44d47) to head (755a9cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   90.88%   90.95%   +0.07%     
==========================================
  Files          13       14       +1     
  Lines        2227     2267      +40     
  Branches      410      414       +4     
==========================================
+ Hits         2024     2062      +38     
- Misses        116      118       +2     
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit 553db2b into main May 21, 2024
8 checks passed
@jmmshn jmmshn deleted the kumagai branch May 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant