-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install optional boltztrap2
and pygraphviz
in CI
#3786
Conversation
fa94c5a
to
45e0dc7
Compare
…to install-opt-dep
do we want to merge this as partially complete and leave some of the todos for later? |
Thanks for asking. I was facing some resistance while trying to install them (maybe that's the reason they're not installed in CI). And what make things worse is that I never use any of these.
UPDATE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @DanielYang59! 👍
Head branch was pushed to by a user without write access
Regarding the installation of I would look into why |
@@ -933,7 +933,7 @@ def draw_graph_to_file( | |||
d["label"] = f"{d['weight']:.2f} {units}" | |||
|
|||
# update edge with our new style attributes | |||
g.edges[u, v, k] |= d | |||
g.edges[u, v, k].update(d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janosh Forgot to mention this, I have to revert your update -> |=
change here c67abbc because it seems to break unit test.
I haven't got a chance to look closer yet, perhaps the operator is not well defined for edges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i noticed that, that was sloppy refactoring on my part. thanks for fixing!
perhaps the operator is not well defined for edges
that's very likely correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was sloppy refactoring on my part.
pygraphviz
was not installed in CI at that time, so there's no way for you to catch that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, but i could have noticed that g.edges[u, v, k]
is unlikely to be a dict
in which case the first thought is to check whether the class in question implements __or__
. (if not, |=
is undefined behavior)
boltztrap2
and pygraphviz
in CI
Summary
bader_caller
(settingPATH
to empty is easier than changing thepatch
location, and serves the same result wherebader
cannot be found inPATH
)Partially installed on Ubuntu
boltztrap2
: only withpip
(uv
wouldn't work for now Installation ofBoltzTraP2
fails astral-sh/uv#5816 (comment))pygraphviz
: installation guide