Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license:remove Doesn't Work for XML_PER_LINE #191

Closed
emmberk opened this issue Dec 14, 2020 · 1 comment · Fixed by #234
Closed

license:remove Doesn't Work for XML_PER_LINE #191

emmberk opened this issue Dec 14, 2020 · 1 comment · Fixed by #234
Assignees
@mathieucarbou
Labels
in:core MLP core module is:bug Bugs to fix
Milestone
4.2

Comments

@emmberk
Copy link

emmberk commented Dec 14, 2020

Plugin definition:

<plugin>
    <groupId>com.mycila</groupId>
    <artifactId>license-maven-plugin</artifactId>
    <version>4.0.rc2</version>
    <configuration>
        <header>license-header.txt</header>
        <includes>
            <include>**/*.xml</include>
        </includes>
        <mapping>
            <xml>XML_PER_LINE</xml>
        </mapping>
    </configuration>
    <executions>
        <execution>
            <goals>
                <goal>check</goal>
            </goals>
        </execution>
    </executions>
</plugin>

license:check and license:format appear to work, but license:remove doesn't actually remove any of the headers.
@mathieucarbou mathieucarbou self-assigned this Sep 1, 2021
@mathieucarbou mathieucarbou added the is:bug Bugs to fix label Sep 1, 2021
@mathieucarbou mathieucarbou added this to the 4.2 milestone Sep 1, 2021
@mathieucarbou mathieucarbou added in-triage is:support Support, help or questions todo Accepted items from the backlog which can be worked on and removed is:bug Bugs to fix in-triage labels Sep 7, 2021
@mathieucarbou mathieucarbou removed this from the 4.2 milestone Sep 7, 2021
@mathieucarbou mathieucarbou removed their assignment Sep 7, 2021
@mathieucarbou mathieucarbou added the in:core MLP core module label Sep 8, 2021
@mathieucarbou mathieucarbou self-assigned this Sep 18, 2021
@mathieucarbou mathieucarbou added is:bug Bugs to fix todo Accepted items from the backlog which can be worked on and removed todo Accepted items from the backlog which can be worked on is:support Support, help or questions labels Sep 18, 2021
@mathieucarbou mathieucarbou added this to the 4.2 milestone Sep 18, 2021
@mathieucarbou
Copy link
Owner

thanks! yes its a bug, I can reproduce!

mathieucarbou added a commit that referenced this issue Sep 18, 2021
@mathieucarbou
Fix #191
44476a0
@mathieucarbou mathieucarbou linked a pull request Sep 18, 2021 that will close this issue
Fix #191 #234
Merged
@mathieucarbou mathieucarbou removed the todo Accepted items from the backlog which can be worked on label Sep 18, 2021
mathieucarbou added a commit that referenced this issue Sep 19, 2021
@mathieucarbou
Fix license removal for a couple of header types (incl. fix #191)
01a36ba
mathieucarbou added a commit that referenced this issue Sep 19, 2021
@mathieucarbou
Merge pull request #234 from mathieucarbou/bugs/191
9d4bdfb 
Fix #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathieucarbou mathieucarbou

Labels
in:core MLP core module is:bug Bugs to fix
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Fix #191 mathieucarbou/license-maven-plugin
2 participants
@mathieucarbou @emmberk