Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make non-shown regions be display:none (mathjax/mathJax#3001) #1072

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 9, 2024

This PR makes the various regions be display: none when not in use, so that there are not small white "artifacts" floating around when they are not being used.

I've made the non-show versions be just display: none, and moved any needed CSS from there to the _show version.

Fixes issue mathjax/MathJax#3001.

@dpvc dpvc requested a review from zorkow March 9, 2024 20:24
@dpvc dpvc added this to the v4.0 milestone Mar 9, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 75897a0 into develop Mar 16, 2024
@dpvc dpvc deleted the region-css branch March 16, 2024 19:36
@dpvc dpvc changed the title Make non-shown regions be display:none Make non-shown regions be display:none (mathjax/mathJax#3001) Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants