Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the AllPackages file, the all-packages TeX extension and the tex-full component #1110

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 25, 2024

This PR removes the AllPackages.ts file, the all-packages TeX extension, and the tex-full component. Since these no longer include all packages anyway, and we no longer make -full versions of the components, these are misleading and problematic in other ways.

The dependencies and source files are modified to remove these packages as well.

As an aside, it used to be that AllPackages was used in the v4-lab to get the TeX packages, but that is now being done using the source.js file, so AllPackages is not used anywhere any more.

@dpvc dpvc requested a review from zorkow June 25, 2024 11:11
@dpvc dpvc added this to the v4.0 milestone Jun 25, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit f506131 into develop Jun 27, 2024
@dpvc dpvc deleted the remove-allpackages branch June 27, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants