Better validation of style values #1121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of CSS styles, in particular the use of quotation marks and backslashes in CSS style values, and sanitizes CSS values when output as a string, avoiding a potential for CSS insertion. It also replaces newlines by spaces to avoid some unusual parsing by browsers that newlines can cause.
The parsing of a CSS string now handles quoted material properly, and in the case that a value includes an unmatched quotation mark, one is appended to make sure they are matched. When outputting a CSS value, the value is trimmed at the first unquoted semi-colon to avoid the possibility of having the value insert additional unexpected CSS rules.
I will make some tests for this in a separate PR.