-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation cleanup #1135
Documentation cleanup #1135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks for doing all the work on this. I have made a few minor comments and suggestions, but otherwise, ready to go.
*/ | ||
protected filterAttribute(_name: string, value: string) { | ||
protected filterAttribute(_name: string, value: string): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this function and filterClassList()
below are never actually used. They were meant for the Safe extension to override, but that is done in a different way now, so they are really superfluous, and probably should be removed (together with the calls in this file that go to them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought they are overwritten in ui/safe
extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lines here and following:
MathJax-src/ts/ui/safe/SafeHandler.ts
Line 94 in 844ad75
if (jax.name.match(/MathML/)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I thought I had searched for them, but mist have done it incorrectly. Thanks for finding them.
Took care of all your points, with the exception of |
This cleans up the majority of the jsdoc documentation.
There are still a few
jsdoc
linter warnings, that have to do withreturns
type. These are sometimes too awkward to include, when they are major template types. We should have a think about them.Also removes unused
.eslintrc
file and minimizes rule customization.