Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CommonHTML] equation label not properly aligned in large arrays with many labels #1500

Closed
pkra opened this issue Jun 2, 2016 · 6 comments
Closed
Labels
Accepted Issue has been reproduced by MathJax team Test Available

Comments

@pkra
Copy link
Contributor

pkra commented Jun 2, 2016

Examples

  • Tags become vertically lower than the cell
 \begin{eqnarray} 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
 a \tag{tag}\\ 
  \end{eqnarray}
  • Tags become vertically higher than the cell
\begin{eqnarray} 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
&& a \tag{tag}\\ 
 \end{eqnarray}

Screenshot (combined)

labels

@pkra pkra added the Accepted Issue has been reproduced by MathJax team label Jun 2, 2016
@pkra pkra added this to the MathJax v2.x.x milestone Jun 2, 2016
@pkra
Copy link
Contributor Author

pkra commented Jun 2, 2016

Oh wow. 1500 bugs!

@dpvc
Copy link
Member

dpvc commented Jun 6, 2016

It turns out that there were several issues that contributed to this. One was that the heights of the lines were being adjusted to the wrong value (argh). But there were also issues with empty cells (it turns out inline-block nodes with no text content align differently from those with text content), and with nodes whose height is less than the midpoint of the font (didn't appear in your examples, but did in my own tests).

I think I have taken care of all of them in the issue1500 branch of my fork of MathJax.

dpvc added a commit to dpvc/MathJax that referenced this issue Jun 6, 2016
…d issues with cells containing no text and cells that are shorter than the midpoint of the font. Resolves issue mathjax#1500.
dpvc added a commit that referenced this issue Jun 8, 2016
Handle adjusting cell heights properly. #1500
@dpvc
Copy link
Member

dpvc commented Jun 8, 2016

==> Merged.

@dpvc
Copy link
Member

dpvc commented Jun 14, 2016

Oh wow. 1500 bugs!

Well, because pull requests use the same numbers as issues (and we've been using more pull requests lately), there aren't really 1500 bugs. There are 1220 issues (not all of them bugs) and 204 pull requests as of this posting. So I'm not sure what the other items 76 are!

@pkra
Copy link
Contributor Author

pkra commented Jun 15, 2016

So I'm not sure what the other items 76 are!

Hm... the numbers I see do add up (maybe you had a filter on?) But yes, over 200 PRs in total -- still awesome :-)

dpvc added a commit to dpvc/MathJax that referenced this issue Jun 22, 2016
…ld reduce the round-off problems by forcing each row to the desired height, and doing the same with the labels. Resolves issue mathjax#1532 (and mathjax#1500).
@dpvc
Copy link
Member

dpvc commented Aug 18, 2016

==> In testsuite

MathMLToDisplay/Presentation/TablesAndMatrices/issue1532.html

@dpvc dpvc removed the Merged Merged into develop branch label Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issue has been reproduced by MathJax team Test Available
Projects
None yet
Development

No branches or pull requests

2 participants