Use a new approach to aligning labels with their table rows. #1532 #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld reduce the round-off problems by forcing each row to the desired height, and doing the same with the labels. Resolves issue mathjax#1532 (and mathjax#1500).
| if (T) LABELS[i].style.marginTop = CHTML.Em(T); | ||
| T = d - lbox.d; | ||
| T = state.RH[i] - Math.max(1,lbox.h); | ||
| if (T) LABELS[i].firstChild.firstChild.style.marginTop = CHTML.Em(T); |
There was a problem hiding this comment.
These are all guaranteed to exist?
There was a problem hiding this comment.
If you mean the first child.firstchild then yes. if you mean the various array elements indexed by [i], then yes.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a new approach to aligning labels with their table rows that should reduce the round-off problems by forcing each row to the desired height, and doing the same with the labels. Resolves issue #1532 (and #1500).