Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecking "Include in Tab Order" doesn't work as expected #2786

Closed
nlotz63 opened this issue Oct 11, 2021 · 1 comment
Closed

Unchecking "Include in Tab Order" doesn't work as expected #2786

nlotz63 opened this issue Oct 11, 2021 · 1 comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed v3 v3.2
Milestone

Comments

@nlotz63
Copy link

nlotz63 commented Oct 11, 2021

In the accessibility menu, unchecking "Include in Tab Order" only works the first time you uncheck it. Although the setting is saved to local storage, returning to a page with math the setting is ignored. In other words, math will be in the tab order.

MathJax version 3.2.0
Windows 10
MS Edge, FireFox, Chrome

To reproduce using the MathJax samples page, go the MathJax samples page:

  1. Tab to some math.
  2. Right click and uncheck "include in tab order" (if you previously unchecked the option, you'll see that the option is unchecked, but the setting was ignored.)
  3. Confirm math is no longer included in the tab order
  4. Refresh the window
  5. The expected behavior is tabbing will skip math; however, tab to some math (include in tab order should still be unchecked because of saved preferences)
  6. Confirm that the "include in tab order" option is unchecked.
  7. Check the "include and tab order" option and then uncheck it. Math should no longer be included in the tab order.

To summarize, after refreshing the window, it remembers your preference (looking in local storage confirms this); however, it ignores the menu setting and includes math in the tab order. I've tried other settings like explorer and click to zoom and they work as expected.

@dpvc dpvc changed the title Unchecking "Include in Tab Order doesn't work as expected Unchecking "Include in Tab Order" doesn't work as expected Dec 2, 2021
@dpvc dpvc self-assigned this Jan 11, 2022
dpvc added a commit to mathjax/MathJax-src that referenced this issue Feb 2, 2022
…ive MML and renderer, which where not in sync with their menu setting after a reload. (mathjax/MathJax#2786)
dpvc added a commit to mathjax/MathJax-src that referenced this issue Feb 2, 2022
@dpvc dpvc added Accepted Issue has been reproduced by MathJax team Ready for Review v3 labels Feb 2, 2022
@dpvc
Copy link
Member

dpvc commented Feb 2, 2022

Sorry for the long delay in getting back to you on this. We are putting together a new release, and I've made a PR that should resolve the issue. It turns out that a number of the settings weren't sticky, and this is one of them. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed v3 v3.2
Projects
None yet
Development

No branches or pull requests

2 participants