Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-build.yml #7

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Create docker-build.yml #7

merged 1 commit into from
Jan 3, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 19, 2023

Signed-off-by: Simon L <szaimen@e.mail.de>
Comment on lines +30 to +31
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would need to add these as action secrets in the repo settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even the free account on docker hub is sufficient btw. You don't need to buy any subscription there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasdelellis you will need to add these secrets to the repo if not done already...

context: './'
no-cache: true
file: 'Dockerfile'
tags: matiasdelellis/facerecognition-external-model:${{ github.event.inputs.tagName }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name can be changed of course to something else if required

@szaimen
Copy link
Contributor Author

szaimen commented Nov 19, 2023

@matiasdelellis would you mind reviewing this?

@matiasdelellis
Copy link
Owner

Great.. Thanks you so much!!!. 😄
I had a lot of work. These days I hope to dedicate a little love to these projects.

@matiasdelellis matiasdelellis merged commit 075898c into matiasdelellis:master Jan 3, 2024
@szaimen
Copy link
Contributor Author

szaimen commented Jan 3, 2024

@matiasdelellis after adding the secrets to the repo, you should be able to create a new docker image by going to https://github.com/matiasdelellis/facerecognition-external-model/actions/workflows/docker-build.yml and then using the run workflow button...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants