feat: can resume and dump from string

[yihong0618]

fix: #4
@matin

[matin]

My main comments:

1. Methods should be called dumps() and loads() to stay consistent with the same pattern used elsewhere in Python
2. base64 only makes the strings longer. Could you give it a try without that?

[matin]

Using base64 is ok. So, to merge:

1. Change method names to dumps() and loads()
2. Add tests to keep coverage at 100%

[yihong0618]

for the reason use base64, for GitHub actions secret or other its easy to copy paste, especially for some users that do not know much about code.

for 1, its ok for me, will change it(but my question is do I need to change resume_from_string either?
for 2, will do it

[matin]

I would get rid of garth.resume_from_string() and garth.save_to_string() and use garth.client.loads() and garth.client.dumps() instead.

I only added save() and resume() at the top level to make it easier to read in Jupyter Notebooks, but with your use case, I wouldn't add it.

[yihong0618]

OK, will fix my repo and added test tomorrow, thanks again for your great repo, and good night(good day)

[yihong0618]

@matin done and left a few review

[yihong0618]

I think we can support 3.8

[matin]

There are open issues with 3.8:

FAILED tests/stats/test_intensity_minutes.py::test_weekly_intensity_minutes - AttributeError: 'tuple' object has no attribute 'week'
FAILED tests/stats/test_steps.py::test_weekly_steps - TypeError: unsupported operand type(s) for |: 'dict' and 'dict'
FAILED tests/stats/test_stress.py::test_daily_stress - TypeError: unsupported operand type(s) for |: 'dict' and 'dict'
FAILED tests/stats/test_stress.py::test_daily_stress_pagination - TypeError: unsupported operand type(s) for |: 'dict' and 'dict'

We can make the necessary changes to support 3.8, but I recommend doing so outside of this PR.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (899b726) 99.79% compared to head (49c5304) 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main        #5      +/-   ##
===========================================
+ Coverage   99.79%   100.00%   +0.20%     
===========================================
  Files          29        29              
  Lines         980       996      +16     
===========================================
+ Hits          978       996      +18     
+ Misses          2         0       -2     

Flag	Coverage Δ
unittests	100.00% <100.00%> (+0.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
garth/__init__.py	100.00% <ø> (ø)
garth/http.py	100.00% <100.00%> (ø)
tests/conftest.py	100.00% <100.00%> (+2.46%)	⬆️
tests/test_http.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yihong0618]

will fix the change in python3.8
some datetime and dict compare need fix....let me fix that.

[matin]

@yihong0618 with the exception of 3.8, looks great!

Could you remove 3.8 support? It can always be resolved outside of this PR.

[yihong0618]

of course, dropping it

[matin]

@yihong0618 published as version 0.4.28. Thanks for the contribution!