-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undo a breaking change #85
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ConnectAPI
Client->>ConnectAPI: request user profile
ConnectAPI-->>Client: return user profile data
Client->>Client: set _user_profile
Client->>Client: return user_profile
Client->>Client: return profile (alias for user_profile)
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (1)tests/test_http.py (1)Pattern
🔇 Additional comments (7)garth/version.py (1)
The patch version increment (0.5.1 → 0.5.2) is appropriate for this backward-compatibility restoration. tests/test_http.py (2)
The test correctly verifies that the username property initializes and populates the user profile.
The test properly verifies that the new garth/http.py (4)
The private attribute has been renamed from
The
The new
The Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 1326 1335 +9
=========================================
+ Hits 1326 1335 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
add
Client.profile
back in to avoid a breaking change like #73 (comment)Summary by CodeRabbit
New Features
profile
property in the Client class to enhance user profile access.Bug Fixes
Chores