Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.15.0 #198

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Release 1.15.0 #198

merged 4 commits into from
Sep 15, 2022

Conversation

matklad
Copy link
Owner

@matklad matklad commented Sep 15, 2022

No description provided.

@matklad matklad changed the title 1.15.0 Release 1.15.0 Sep 15, 2022
@matklad
Copy link
Owner Author

matklad commented Sep 15, 2022

bors r+

bors bot added a commit that referenced this pull request Sep 15, 2022
198: Release 1.15.0 r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 15, 2022

Canceled.

@matklad
Copy link
Owner Author

matklad commented Sep 15, 2022

bors r+

@matklad
Copy link
Owner Author

matklad commented Sep 15, 2022

NB: this bump MSRV to 1.56.0. I think this should be fine, but, if you have specific objection to that, I'd love to hear.

This PR pushes 1.15.0-pre.1, I'll upgrade that to 1.15.0 proper next week.

@bors
Copy link
Contributor

bors bot commented Sep 15, 2022

Build succeeded:

  • Rust

@bors bors bot merged commit 5ca60af into master Sep 15, 2022
@bors bors bot deleted the 1.15.0 branch September 15, 2022 23:20
@notgull
Copy link

notgull commented Sep 16, 2022

My main objection is that Debian stable still uses Rust 1.48, so this would prevent crates I maintain that are dependent on this crate from building on there.

@matklad
Copy link
Owner Author

matklad commented Sep 16, 2022

re-reading rust-lang/libs-team#72, I think my stance on that is that once-cell intends to support projects which generally keep with up-to-date Rust, while also providing generous comparability window. It is a non-goal to support use-cases which have to use old compilers without intention to upgrade.

For debian-stable-like specifically, I think the reasonable choices are:

  • install a more recent Rust using rustup
  • if using old compiler is required, use old version of libraries as well
  • if combination of old compiler and new library is required, it's on the consumer to patch the library on their side

This is based primarily on two observations:

  • overall Rust ecosystem policy is closer to "live at head". When Rust policy clashes with distro policy, Rust policy is preferred
  • practically, it seems relatively few people are stuck with as old Rust as debian stable, so this shouldn't have a big practical impact. And, arguably, those people who are impacted could be advised to find a way to use a supported version of Rust

@matklad
Copy link
Owner Author

matklad commented Sep 20, 2022

From tokio discussion:

Tokio has MSRV of 6 month, but it also has a 12 month LTS, which means that effective MSRV for tokio is 18.

I don't think it makes sense for once_cell to chase downstream LTS promises (which is a restatement of the policy above that says that once_cell generally caters to users who aspire to use a somewhat up-to-date compiler).

So, I'll cut a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants