Run tests on PHP 8.4 instead of PHP 8.3 #22667
Merged
+36
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
php84
branch
9 times, most recently
from
c5970da
to
5b4b94a
Compare
sgiehl
added
the
c: Tests & QA
sgiehl
force-pushed
the
php84
branch
6 times, most recently
from
fb1c343
to
78a8547
Compare
11 tasks
sgiehl
force-pushed
the
php84
branch
3 times, most recently
from
e2f16b0
to
f88d9fe
Compare
sgiehl
changed the title
michalkleiner
previously approved these changes
Oct 22, 2024
Co-authored-by: Michal Kleiner <michal@innocraft.com> Co-authored-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
michalkleiner
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains a couple of changes / fixes for PHP 8.4
This is required, as we are using a couple of vendor libraries, that are not compatible with PHP 8.4. Updating them is not possible as long as we support PHP < 8
E_STRICTis useddisplay_errors = 0, to ensure no deprecation notices are printed within the javascript codeLast Test run with all test suites on PHP 8.4: https://github.com/matomo-org/matomo/actions/runs/11437068780?pr=22667
fixes #22471
Review