Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style for AdBlock warning #22692

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

AnandaCampelo
Copy link
Contributor

Description:

This PR updates the adblock detection script to display the warning message at the top of the page, styled to ensure it is clearly visible and centered inside the box.

Fixes #17784

Review

@sgiehl sgiehl added this to the 5.2.0 milestone Oct 17, 2024
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the changes locally and it now looks like this:

image

Thanks for your contribution @AnandaCampelo

@sgiehl sgiehl added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Oct 17, 2024
@sgiehl sgiehl merged commit d14312d into matomo-org:5.x-dev Oct 17, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install routine: "In case you are using an ad blocker, please ..."
2 participants