Set rooms invite only #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this does not set existing bridge rooms as invite only. You must send/receive a message to/from the room for it to be set as invite only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndrewJDR , tested this today, by creating a new Slack user ("installing" Simple Poll, which causes a new user to join my Slackbot 1:1 room), then verifying that the room as set invite-only, then kicking the bot and uninstalling the app, then doing it again to see if the bot was able to join. It was!
Gonna go ahead and create a PR myself to merge this. Thanks a ton; this was a big deficiency.