Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triage-incoming.yml #14

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Add triage-incoming.yml #14

merged 4 commits into from
Oct 18, 2022

Conversation

Half-Shot
Copy link
Collaborator

@Half-Shot Half-Shot commented Oct 18, 2022

@Half-Shot Half-Shot marked this pull request as ready for review October 18, 2022 16:32
@Half-Shot Half-Shot requested a review from a team as a code owner October 18, 2022 16:32
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some warnings in the linked run---don't know if they're something we should worry about? Otherwise LGTM.

Would you mind changing Synapse to point to this?

Also, are you up for doing a release? (Merge PR, create github release with semver bump, force push the v1 tag to point at the release's tag)

@Half-Shot
Copy link
Collaborator Author

The warning looks like a fault with the module (it seems to do the same thing with Synapse, and we're definitely using the intended syntax https://github.com/matrix-org/synapse/actions/runs/3274133082)

Would you mind changing Synapse to point to this?

Yeah, can do post release.

Also, are you up for doing a release? (Merge PR, create github release with semver bump, force push the v1 tag to point at the release's tag)

Yeah, can do!

@Half-Shot Half-Shot merged commit 608d45d into release/v1 Oct 18, 2022
@Half-Shot Half-Shot deleted the hs/move-new-issues branch October 18, 2022 21:38
Half-Shot added a commit to matrix-org/synapse that referenced this pull request Oct 18, 2022
@DMRobertson
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants