Skip to content

Commit

Permalink
Remove Synapse-specific dockerfiles (#359)
Browse files Browse the repository at this point in the history
matrix-org/synapse#12404 moved these to the Synapse
repo.
  • Loading branch information
richvdh authored Apr 21, 2022
1 parent 378201f commit 7ed9dbd
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 501 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ jobs:
# Build homeserver image

# Build the base Synapse dockerfile and then build a Complement-specific image from that base.
- run: docker build -t matrixdotorg/synapse:latest -f docker/Dockerfile .
- run: |
docker build -t matrixdotorg/synapse:latest -f docker/Dockerfile .
docker build -t homeserver -f docker/complement/Dockerfile docker/complement
if: ${{ matrix.homeserver == 'Synapse' }}
working-directory: homeserver
env:
DOCKER_BUILDKIT: 1
- run: docker build -t homeserver -f dockerfiles/${{ matrix.homeserver }}.Dockerfile dockerfiles/
if: ${{ matrix.homeserver == 'Synapse' }}
# Build the Complement-specific dendrite image from the dockerfile in the Dendrite repo.
# We don't use the dockerfiles in the Complement repo as they tend to get stale quickly.
Expand Down
15 changes: 10 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,22 @@ $ COMPLEMENT_BASE_IMAGE=complement-dendrite:latest go test -v ./tests/...

If you're looking to run Complement against a local dev instance of Synapse, see [`matrix-org/synapse` -> `scripts-dev/complement.sh`](https://github.com/matrix-org/synapse/blob/develop/scripts-dev/complement.sh).

If you want to develop Complement tests while working on a local dev instance of Synapse, use the [`scripts-dev/complement.sh`](https://github.com/matrix-org/synapse/blob/develop/scripts-dev/complement.sh) script and set the `COMPLEMENT_DIR` environment variable to the filepath of your local Complement checkout. A regex that matches against test names can also be supplied as an argument to the script, i.e:
If you want to develop Complement tests while working on a local dev instance
of Synapse, use the
[`scripts-dev/complement.sh`](https://github.com/matrix-org/synapse/blob/develop/scripts-dev/complement.sh)
script and set the `COMPLEMENT_DIR` environment variable to the filepath of
your local Complement checkout. Arguments to `go test` can be supplied as an argument to the script, e.g.:

```sh
COMPLEMENT_DIR=/path/to/complement scripts-dev/complement.sh "TestOutboundFederation(Profile|Send)"
COMPLEMENT_DIR=/path/to/complement scripts-dev/complement.sh -run "TestOutboundFederation(Profile|Send)"
```

To run Complement against a specific release of Synapse, set the
`SYNAPSE_VERSION` build argument. For example:
To run Complement against a specific release of Synapse, build the
"complement-synapse" image with a `SYNAPSE_VERSION` build argument. For
example:

```sh
docker build -t complement-synapse:v1.36.0 -f dockerfiles/Synapse.Dockerfile --build-arg=SYNAPSE_VERSION=v1.36.0 dockerfiles
(cd synapse && docker build -t complement-synapse:v1.36.0 -f docker/complement/Dockerfile --build-arg=SYNAPSE_VERSION=v1.36.0 docker/complement)
COMPLEMENT_BASE_IMAGE=complement-synapse:v1.36.0 go test ./tests/...
```

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ end up copying the Dockerfiles in this directory to their own repository. In an
duplication, we now point to dockerfiles in respective repositories rather than have them directly here.

- Dendrite: https://github.com/matrix-org/dendrite/blob/v0.6.3/build/scripts/Complement.Dockerfile
- Synapse: https://github.com/matrix-org/synapse/blob/v1.52.0/scripts-dev/complement.sh
- Synapse: https://github.com/matrix-org/synapse/blob/develop/docker/complement/Dockerfile
36 changes: 0 additions & 36 deletions dockerfiles/Synapse.Dockerfile

This file was deleted.

73 changes: 0 additions & 73 deletions dockerfiles/SynapseWorkers.Dockerfile

This file was deleted.

9 changes: 0 additions & 9 deletions dockerfiles/keys/README.md

This file was deleted.

21 changes: 0 additions & 21 deletions dockerfiles/keys/ca.crt

This file was deleted.

27 changes: 0 additions & 27 deletions dockerfiles/keys/ca.key

This file was deleted.

76 changes: 0 additions & 76 deletions dockerfiles/synapse/caddy.complement.json

This file was deleted.

Loading

0 comments on commit 7ed9dbd

Please sign in to comment.