Skip to content

Commit

Permalink
Test content disposition against a content type with a parameter. (#664)
Browse files Browse the repository at this point in the history
  • Loading branch information
clokep authored Oct 11, 2023
1 parent ac0371e commit db5b96f
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions tests/media_filename_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,25 @@ func TestMediaFilenames(t *testing.T) {
}
})

t.Run("Will serve safe media types with parameters as inline", func(t *testing.T) {
if runtime.Homeserver != runtime.Synapse {
// We need to check that this security behaviour is being correctly run in
// Synapse, but since this is not part of the Matrix spec we do not assume
// other homeservers are doing so.
t.Skip("Skipping test of Content-Disposition header requirements on non-Synapse homeserver")
}
t.Parallel()

// Add parameters and upper-case, which should be parsed as text/plain.
mxcUri := alice.UploadContent(t, data.MatrixPng, "", "Text/Plain; charset=utf-8")

_, isAttachment := downloadForFilename(t, bob, mxcUri, "")

if isAttachment {
t.Fatal("Expected file to be served as inline")
}
})

t.Run("Will serve unsafe media types as attachments", func(t *testing.T) {
if runtime.Homeserver != runtime.Synapse {
// We need to check that this security behaviour is being correctly run in
Expand Down

0 comments on commit db5b96f

Please sign in to comment.