Skip to content

Commit

Permalink
Handle transactions sent during UnverifiableEvents test (#59)
Browse files Browse the repository at this point in the history
Once again Synapse likes to send presence when it joins a room. I wonder if we
should perhaps make federation.HandleTransactionRequests default for new
servers, with the ability to override it if desired?

The only thing I worry about there is that you may want a test that 404's on
transactions.  Maybe at that point we could just extend
HandleTransactionRequests to return custom responses.
  • Loading branch information
anoadragon453 authored Jan 6, 2021
1 parent 6782b5e commit ee3715d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/federation_room_join_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ func TestJoinFederatedRoomWithUnverifiableEvents(t *testing.T) {
srv := federation.NewServer(t, deployment,
federation.HandleKeyRequests(),
federation.HandleMakeSendJoinRequests(),
federation.HandleTransactionRequests(nil, nil),
)
srv.UnexpectedRequestsAreErrors = false
cancel := srv.Listen()
Expand Down

0 comments on commit ee3715d

Please sign in to comment.