Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace COMPLEMENT_VERSION_CHECK_ITERATIONS #232

Closed
kegsay opened this issue Nov 19, 2021 · 0 comments · Fixed by #234
Closed

Replace COMPLEMENT_VERSION_CHECK_ITERATIONS #232

kegsay opened this issue Nov 19, 2021 · 0 comments · Fixed by #234

Comments

@kegsay
Copy link
Member

kegsay commented Nov 19, 2021

It's really not clear what this is supposed to do, and what it controls. It ultimately controls how long we're willing to wait for the HS to deploy when using docker run so rename it to COMPLEMENT_SPAWN_HS_TIMEOUT_SECS perhaps. Given we sleep a bit between checks, we can deprecate COMPLEMENT_VERSION_CHECK_ITERATIONS and automatically convert it to a time in the new format.
kegsay added a commit that referenced this issue Nov 19, 2021
@kegsay
Replace COMPLEMENT_VERSION_CHECK_ITERATIONS with COMPLEMENT_SPAWN_HS_…
1568a70 
…TIMEOUT_SECS

The new name is clearer and easier to understand. Fixes #232.

Currently, Complement will still accept the old env var but will log a Deprecated
warning. Homerunner will just look for the new env var HOMERUNNER_SPAWN_HS_TIMEOUT_SECS
and will ignore the old env var.
@kegsay kegsay mentioned this issue Nov 19, 2021
Merged
kegsay added a commit that referenced this issue Nov 22, 2021
@kegsay
Replace COMPLEMENT_VERSION_CHECK_ITERATIONS with COMPLEMENT_SPAWN_HS_…
eb57e1e 
…TIMEOUT_SECS (#234)

The new name is clearer and easier to understand. Fixes #232.

Currently, Complement will still accept the old env var but will log a Deprecated
warning. Homerunner will just look for the new env var HOMERUNNER_SPAWN_HS_TIMEOUT_SECS
and will ignore the old env var.
michaelkaye added a commit to michaelkaye/synapse that referenced this issue Nov 25, 2021
@michaelkaye
Swap to COMPLEMENT_SPAWN_HS_TIMEOUT_SECS env var.
608d538 
This was changed in matrix-org/complement#232 and the result should be
identical (50ms * 500 == 25s)
michaelkaye added a commit to michaelkaye/synapse that referenced this issue Jan 10, 2022
@michaelkaye
Swap to COMPLEMENT_SPAWN_HS_TIMEOUT_SECS env var.
ce9c1bc 
This was changed in matrix-org/complement#232 and the result should be
identical (50ms * 500 == 25s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kegsay