Regression test for infinite-loop-in-resync #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rather commplicated test which demonstrated that the infinite loop was possible.
kegsay
reviewed
Jul 22, 2022
kegsay
reviewed
Jul 22, 2022
Co-authored-by: kegsay <kegan@matrix.org>
|
seems like this would benefit from some of the utility functions added in #419. I'll update it once that lands. |
richvdh
force-pushed
the
rav/fix_resync_loop
branch
from
2e06591
to
48f31be
Compare
squahtx
reviewed
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rather complicated test which demonstrated that the infinite loop was in matrix-org/synapse#13001 was possible.
The test currently fails: it's getting stuck waiting for soft-fail, which is something @squahtx is working on.