Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application service support to blueprints #74

Merged
merged 7 commits into from
Feb 23, 2021
Merged

Add application service support to blueprints #74

merged 7 commits into from
Feb 23, 2021

Commits on Feb 22, 2021

  1. Add application service support to blueprints 

    Split out from #68
    @MadLittleMods
    MadLittleMods committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    cf4d8e9 View commit details
    Browse the repository at this point in the history

  2. Revert always showing logs

    @MadLittleMods
    MadLittleMods committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    ccb20e6 View commit details
    Browse the repository at this point in the history

  3. Add comment doc

    @MadLittleMods
    MadLittleMods committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    12e6ec0 View commit details
    Browse the repository at this point in the history

  4. Some nits and remove the volume paths 

     - Seems like the `Volumes` syntax is to create an anonymous volume, https://stackoverflow.com/a/58916037/796832
 - And lots of people not knowing what `Volumes` syntax is or what to do. Seems like Mounts is the thing to use
    - fsouza/go-dockerclient#155
    - https://stackoverflow.com/questions/55718603/golang-docker-library-mounting-host-directory-volumes
    - https://stackoverflow.com/questions/48470194/defining-a-mount-point-for-volumes-in-golang-docker-sdk
    @MadLittleMods
    MadLittleMods committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    1b19990 View commit details
    Browse the repository at this point in the history

  5. Address review and add comment docs

    @MadLittleMods
    MadLittleMods committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c1f07c2 View commit details
    Browse the repository at this point in the history

  6. Revert lint change already in other PR #73

    @MadLittleMods
    MadLittleMods committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    169a60d View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Path escape AS IDs to avoid directory traversal attacks

    @kegsay
    kegsay committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c6155af View commit details
    Browse the repository at this point in the history