Use stable identifiers from MSC3706 (Faster joins) #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 48.15% // Head: 48.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 48.15% 48.19% +0.03%
==========================================
Files 37 37
Lines 5889 5889
==========================================
+ Hits 2836 2838 +2
+ Misses 2785 2783 -2
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Jan 12, 2023
richvdh
reviewed
Jan 13, 2023
federationtypes.go
Outdated
| @@ -444,9 +444,9 @@ type RespSendJoin struct { | |||
| // but not guaranteed to be present as it's only since MSC3083. | |||
| Event RawJSON `json:"event,omitempty"` | |||
| // true if the state is incomplete | |||
| PartialState bool `json:"org.matrix.msc3706.partial_state"` | |||
| PartialState bool `json:"members_omitted"` | |||
There was a problem hiding this comment.
I kinda wonder if we should rename the struct field while we're here. It'll break compatibility with any apps using it, but there doesn't seem to be any advantage to delaying it?
There was a problem hiding this comment.
Not sure what the done thing is in GMSL, but I'm persuaded.
kegsay
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't made any effort to maintain backwards compatibility (unlike in matrix-org/synapse#14832). I'm happy to do so if needed, but might need some guidance.
Synapse issue: matrix-org/synapse#14828
Synapse PR: matrix-org/synapse#14832
Complement PR: matrix-org/complement#583
GMSL PR: #350
MSC: matrix-org/matrix-spec-proposals#3706
Spec diff: matrix-org/matrix-spec#1393
Pull Request Checklist
Signed-off-by:
David Robertson <davidr@element.io>