Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override config with environment variables #485

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Override config with environment variables #485

merged 3 commits into from
Jun 7, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jun 4, 2019

This adds the possibility for the user to override configuration values by setting environment variables.

For example, one can define the value for auth.botToken by setting APPSERVICE_DISCORD_AUTH_BOT_TOKEN=iDislikeTypescriptAndThisNodejsMadness in the environment.

A unit test has been added for the proposed changes.
This PR also fixes some invalid calls in some other tests.

@pacien
fix some test assertion calls
8c09564 
Signed-off-by: pacien <pacien.trangirard@pacien.net>
@Half-Shot Half-Shot self-requested a review June 4, 2019 22:41
Half-Shot
Half-Shot requested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good as is for me, but can we get a README note to say that this feature exists?

@Half-Shot Half-Shot requested review from Half-Shot and removed request for Half-Shot June 5, 2019 00:18
Half-Shot
Half-Shot approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fat fingered the button

@pacien
add config override using env variables
45d2bf8 
Signed-off-by: pacien <pacien.trangirard@pacien.net>
@pacien
Copy link
Contributor Author

pacien commented Jun 5, 2019

@Half-Shot wrote:

Broadly looks good as is for me, but can we get a README note to say that this feature exists?

Sure, added.

@pacien
add note for config override using env vars
9827b98 
Signed-off-by: pacien <pacien.trangirard@pacien.net>
@pacien pacien mentioned this pull request Jun 5, 2019
Merged
16 tasks
@Half-Shot Half-Shot merged commit 90ea8c8 into matrix-org:develop Jun 7, 2019
@pacien pacien mentioned this pull request Oct 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacien @Half-Shot