feat: add Matrix -> Discord reactions #877
Conversation
| # install some dependencies needed for the build process | ||
| RUN apt update && apt install -y build-essential make gcc g++ python3 ca-certificates libc-dev wget git | ||
|
|
||
| COPY . /tmp/src |
There was a problem hiding this comment.
Nice optimisation for having to build the first step less often. 👍
There was a problem hiding this comment.
Wasn't sure if this should go in it's own PR, I was going to revert it, but yeah, it does speed up building by quite a bit when trying to test changes on a remote machine instead of locally.
EDIT: There's a way to make it even faster by adding just the package.json and yarn.lock files, doing the yarn install, then adding the source code and doing the build separately
Co-authored-by: Christian Paul <christian@chrpaul.de> Signed-off-by: mangofeet <44532162+mangofeet@users.noreply.github.com>
I still need to figure out how to respond to the redaction of a reaction in Matrix. Unfortunately it looks like I may have to figure out a way to store the records differently so that the event ID of the reaction that comes back in I'll be checking out the code that's in #862 to maybe pull some implementation details from there (hopefully without depdending on that PR since it's still in review I guess) |
mangofeet
force-pushed
the
matrix-reactions
branch
from
549af85
to
ded5ef1
Compare
|
OK, so I got reactions redacting from matrix to discord. Still need to figure out the edge case of the thumbs up, but otherwise it's working as I intended now. |
mangofeet
changed the title
|
Handled the thumbs up exception from Matrix to Discord, but not the other way around yet, not sure if that's strictly necessary to merge this though. It may be better to get this and #862 merged, and then handle any emoji exceptions in a unified manner after the fact. |
| let emoji = relatesTo.key | ||
| if (emoji.indexOf("👍") >=0 ) { | ||
| emoji = "👍" | ||
| } |
There was a problem hiding this comment.
After reading this if statement, I'm assuming that this is related to the skin-tones? If so, you may want to do proper parsing of those, as more than thumbs up is affected. There's also country flags which use a similar concept.
Implements reactions from matrix to discord, intended for cases where a single matrix user is using the bot as a personal puppet
Functionality is disabled by default and enable by setting
bridge.enableMatrixReactionstotrue