Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to deactivate users to prevent them from ever being bridged #1021

Merged
merged 12 commits into from
Apr 7, 2020

Conversation

Half-Shot
Copy link
Contributor

A few users have noted that they are re-bridged even after deactivating their account. The bridge will always reconnect users if they join an IRC bridged room. However, due to state resets (a bug where older v1-2 version rooms could revert their state to a previous point in time) these users may end up reappearing in the room. I can't seem to find an actual issue that describes the 'state reset bug', but there you go.

If the user reappears in the room, they may get reconnected even if they have since deleted their account. The IRC bridge should therefore keep track of users who have deactivated their accounts. In the future. MSC2438 will allow us to listen for these deactivation requests, but for now this offers us a manual way to do it.

@Half-Shot Half-Shot requested a review from a team April 7, 2020 09:03
@jaller94 jaller94 self-assigned this Apr 7, 2020
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/irc/ClientPool.ts Outdated Show resolved Hide resolved
@jaller94
Copy link
Contributor

jaller94 commented Apr 7, 2020

The changelog file is empty.

@Half-Shot
Copy link
Contributor Author

Good catch

@jaller94 jaller94 assigned Half-Shot and unassigned jaller94 Apr 7, 2020
@Half-Shot Half-Shot merged commit 65e4831 into develop Apr 7, 2020
@jaller94 jaller94 deleted the hs/user-deactivation branch April 15, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants