Add !quit command to admin rooms #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 26, 2016 11:20
kegsay
reviewed
Oct 26, 2016
| (bridgedClient) => bridgedClient.server.domain === ircServer.domain | ||
| ).forEach((bridgedClient) => { | ||
| bridgedClient.kill(); | ||
| }); |
There was a problem hiding this comment.
No success/failure message sent back?
There was a problem hiding this comment.
They will see metadata about their connection being lost. I could add even more feedback but it would feel redundant.
|
LGTM |
This was referenced Oct 26, 2016
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send
!quit server.nameto kill all bridgedClients that the sending user has associated with the specified server. This required some updates to the connection notices; the one that indicates a disconnect now doesn't read '...Reconnecting' and this has been replaced by a separate notice that says 'Connecting...' when a client is doing so. This does mean that if the server isn't starting up and the clients reconnect for any reason, 3 notices are now seen instead of 2, but I feel like that's a fair trade-off for being better informed.