Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Implementation of MSC3824 actions for compat #221

Merged
merged 5 commits into from
May 31, 2022
Merged

Implementation of MSC3824 actions for compat #221

merged 5 commits into from
May 31, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented May 31, 2022

No description provided.

@hughns hughns requested a review from sandhose May 31, 2022 08:58
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, but overall LGTM

crates/handlers/src/compat/login.rs Outdated Show resolved Hide resolved
crates/handlers/src/compat/login.rs Outdated Show resolved Hide resolved
hughns and others added 3 commits May 31, 2022 10:03
Co-authored-by: Quentin Gliech <quenting@element.io>
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #221 (32153cf) into main (0a32ba3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 32153cf differs from pull request most recent head d1b49cf. Consider uploading reports for the commit d1b49cf to get more accurate results

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   21.63%   21.62%   -0.01%     
==========================================
  Files         129      129              
  Lines        9661     9665       +4     
==========================================
  Hits         2090     2090              
- Misses       7571     7575       +4     
Impacted Files Coverage Δ
crates/handlers/src/compat/login.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a32ba3...d1b49cf. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants