Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2078: Sending Third-Party Request Tokens via the Homeserver #2078

Merged
merged 18 commits into from
Jun 10, 2019
Merged

MSC2078: Sending Third-Party Request Tokens via the Homeserver #2078

merged 18 commits into from
Jun 10, 2019

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jun 5, 2019 •
edited by richvdh
Loading

Rendered

Spec PR is here: #2101

dbkr
dbkr reviewed Jun 5, 2019
View reviewed changes
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
@anoadragon453
Copy link
Member Author

Seeing as people mostly agree about the content, I'm going to propose FCP.

@mscbot fcp merge

@anoadragon453
Copy link
Member Author

anoadragon453 commented Jun 5, 2019 •
edited
Loading

@mscbot fcp merge

Edit: helps if you add the label

@anoadragon453 anoadragon453 added the proposal A matrix spec change proposal label Jun 5, 2019
@turt2live
Copy link
Member

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 5, 2019 •
edited by turt2live
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jun 5, 2019
@anoadragon453 @uhoreg
Update proposals/2078-homeserver-password-resets.md
395acf8 
Co-Authored-By: Hubert Chathi <hubert@uhoreg.ca>
@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 5, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jun 5, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@turt2live turt2live self-requested a review June 5, 2019 15:10
turt2live
turt2live requested changes Jun 5, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please resolve comment threads that are no longer relevant to make the timeline smaller.

proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 mentioned this pull request Jun 7, 2019
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed proposal-in-review labels Jun 10, 2019
@turt2live
Copy link
Member

It seems like it's too late to mention it at this point, however this is a breaking change for clients. Older clients which happily continue using /r0/.../requestToken will be unaware of the new field, leading them to be non-compliant because they'll say "go check your email and click the link" instead of "enter the token from your email".

I don't really know how to fix this without bumping the endpoint version, which is non-trivial for the client-server API.

Just highlighting this as a point of documentation, rather than blocking the whole 1.0 on it. It's certainly not the first time we've broken compatibility between minor versions of the spec, however I strongly suggest this be the last time we ever do this.

@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jun 10, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jun 10, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit fc1d8f1 into master Jun 10, 2019
@anoadragon453 anoadragon453 deleted the anoa/msc2078 branch June 10, 2019 22:42
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 11, 2019
@dbkr dbkr mentioned this pull request Aug 6, 2019
Closed
@jryans jryans added phase:1 privacy-sprint Temporary label: privacy-related stuff labels Sep 20, 2019
This was referenced Sep 20, 2019
Closed
Open
Closed
@richvdh richvdh mentioned this pull request Sep 23, 2019
Merged
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this pull request Oct 8, 2019
@manuroe
Privacy: Sending Third-Party Request Tokens via the Homeserver ([MSC2…
bc53f93 
…078](matrix-org/matrix-spec-proposals#2078)).

element-hq/element-ios#2731
@manuroe manuroe mentioned this pull request Oct 8, 2019
Merged
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this pull request Oct 8, 2019
@manuroe
Privacy: Sending Third-Party Request Tokens via the Homeserver ([MSC2…
aff4b10 
…078](matrix-org/matrix-spec-proposals#2078)).

element-hq/element-ios#2731
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this pull request Oct 8, 2019
@manuroe
MXK3PID: Privacy: Sending Third-Party Request Tokens via the Homeserver
b95efaa 
This implements ([MSC2078](matrix-org/matrix-spec-proposals#2078)).
This is a quick c+p from matrix-org/matrix-ios-sdk#728.
We will completely remove MXK3PID when refactoring login/registration.
@manuroe manuroe mentioned this pull request Oct 8, 2019
Merged
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this pull request Oct 8, 2019
@manuroe
Privacy: Sending Third-Party Request Tokens via the Homeserver ([MSC2…
5bf9bbb 
…078](matrix-org/matrix-spec-proposals#2078)).

element-hq/element-ios#2731
@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

@uhoreg uhoreg uhoreg left review comments

@dbkr dbkr dbkr left review comments

@turt2live turt2live turt2live approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
disposition-merge kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! privacy-sprint Temporary label: privacy-related stuff proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anoadragon453 @turt2live @mscbot @dbkr @uhoreg @richvdh @jryans @neilisfragile