Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all forms of request failure on a feed are not treated as a parsing failure by metrics #816

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Ensure all forms of request failure on a feed are not treated as a parsing failure by metrics #816

merged 4 commits into from
Sep 25, 2023

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Sep 14, 2023 •
edited
Loading

Things like TLS fails and timeouts were coming through as parsing failures, which is unfortunate because it was incorrectly highlighting a bug with our parser.

We also ensure that a lpush is not attempted with a empty array.

@Half-Shot Half-Shot requested a review from a team as a code owner September 14, 2023 09:57
@Half-Shot Half-Shot changed the title hs/cleanup feed errors Ensure all forms of request failure on a feed are not treated as a parsing failure by metrics Sep 14, 2023
@Half-Shot Half-Shot enabled auto-merge September 25, 2023 08:17
@Half-Shot Half-Shot added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit d744974 Sep 25, 2023
14 checks passed
@Half-Shot Half-Shot deleted the hs/cleanup-feed-errors branch September 25, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @AndrewFerr