pr comments

matrix-org · Sep 13, 2024 · d56aff1 · d56aff1
1 parent 278cf8b
commit d56aff1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/.github/workflows/ci-integration-tests.yml b/.github/workflows/ci-integration-tests.yml
@@ -80,7 +80,7 @@ jobs:
         with:
           name: report.junit
           path: build/test/report.junit
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: always()
         with:
           name: MatrixSDK-macOS.xcresult

diff --git a/.github/workflows/ci-unit-tests.yml b/.github/workflows/ci-unit-tests.yml
@@ -50,7 +50,7 @@ jobs:
         run: bundle exec fastlane test testplan:UnitTests
 
       # Store artifacts
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: report.html
           path: build/test/report.html

diff --git a/MatrixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift b/MatrixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift
@@ -116,11 +116,6 @@ class MXCryptoMachine {
         }
     }
 
-    func invalidateCache() async {
-        // Not sure what is the new function for this
-//        await machine.clearCryptoCache()
-    }
-
     // MARK: - Private
 
     private static func createMachine(userId: String, deviceId: String, log: MXNamedLog) throws -> OlmMachine {

diff --git a/MatrixSDK/Crypto/MXCryptoV2.swift b/MatrixSDK/Crypto/MXCryptoV2.swift
@@ -724,8 +724,7 @@ class MXCryptoV2: NSObject, MXCrypto {
 
     func invalidateCache(_ done: @escaping () -> Void) {
         Task {
-            log.debug("Invalidating Olm Machine crypto store cache.")
-            await machine.invalidateCache()
+            // invalidating cache is not required for crypto v2 and is just here for conformance with the original crypto protocol
             await MainActor.run {
                 done()
             }