Improve video transcoding quality #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add maxUploadSize:failure: to MXRestClient and store the size in MXSession. Pass a target file size to MXTools and use AVAssetExportPreset3840x2160 when transcoding.
…VideoToMP4:withTargetFileSize:success:failure
pixlwave
commented
Jul 1, 2021
pixlwave
commented
Jul 1, 2021
pixlwave
commented
Jul 1, 2021
pixlwave
commented
Jul 1, 2021
pixlwave
changed the title
manuroe
reviewed
Jul 1, 2021
Use this preset in MXTools when converting a video.
pixlwave
commented
Jul 2, 2021
| @@ -324,6 +324,21 @@ | |||
| - (void)close; | |||
|
|
|||
|
|
|||
| #pragma mark - Media repository | |||
There was a problem hiding this comment.
Note: these follow an @optional further up, and are only implemented in MXFileStore.
manuroe
reviewed
Jul 5, 2021
Co-authored-by: manuroe <manuroe@users.noreply.github.com>
Co-authored-by: manuroe <manuroe@users.noreply.github.com>
manuroe
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now as I have a couple of questions.
Add
maxUploadSize:failure:toMXRestClientand stores the size inMXSession.Pass a target file size to
MXToolsand useAVAssetExportPreset3840x2160when transcoding.