Don't store streams that are only used once #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
dbkr
approved these changes
Feb 8, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Feb 15, 2022
* Fix issue with rooms not getting marked as unread ([\matrix-org#2163](matrix-org#2163)). Fixes element-hq/element-web#20971. * Don't store streams that are only used once ([\matrix-org#2157](matrix-org#2157)). Fixes element-hq/element-web#20932. Contributed by @SimonBrandner. * Fix edge cases around RR calculations ([\matrix-org#2160](matrix-org#2160)). Fixes element-hq/element-web#20922. * Account for encryption in `maySendMessage()` ([\matrix-org#2159](matrix-org#2159)). Contributed by @SimonBrandner. * Send references to thread root to threads, even out of order ([\matrix-org#2156](matrix-org#2156)). * Fix initial sync fail when event fetching unsuccessful ([\matrix-org#2150](matrix-org#2150)). Fixes element-hq/element-web#20862. * Don't decrypt redacted messages ([\matrix-org#2143](matrix-org#2143)). Contributed by @SimonBrandner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: defect
Notes element-web: Fix enabling video in voice calls working only once
Fixes element-hq/element-web#20932
Without this
MediaHandlerwould always push the stream we used to get a new track while upgrading a call. We don't keep track of that stream in the call itself, so we never callstopUserMediaStream()for it but westop()its tracks. When trying to upgrade a call againMediaHandlerwould try to re-use the stream but its tracks would be empty. Therefore we avoid pushing the stream so that it doesn't get re-usedHere's what your changelog entry will look like:
🐛 Bug Fixes