Fix wrong event_id being sent for m.in_reply_to of threads #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2213 +/- ##
========================================
Coverage 57.63% 57.63%
========================================
Files 90 90
Lines 16263 16263
Branches 3741 3741
========================================
Hits 9373 9373
Misses 6890 6890
|
dbkr
approved these changes
Mar 2, 2022
|
Can we test this? |
|
Its a type failure, should be caught by better typing rather than tests imo |
|
I mean, stronger typing would have prevented this bug, but a test of this function could have prevented many others, right? (E.g. missing this field altogether, or supplying "".) |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Mar 17, 2022
* Improve typing around event emitter handlers ([\matrix-org#2180](matrix-org#2180)). * Fix defer not supporting resolving with a Promise<T> ([\matrix-org#2216](matrix-org#2216)). * add LocationAssetType enum ([\matrix-org#2214](matrix-org#2214)). * Support for mid-call devices changes ([\matrix-org#2154](matrix-org#2154)). Contributed by @SimonBrandner. * Add new room state emit RoomStateEvent.Update for lower-frequency hits ([\matrix-org#2192](matrix-org#2192)). * Fix wrong event_id being sent for m.in_reply_to of threads ([\matrix-org#2213](matrix-org#2213)). * Fix wrongly asserting that PushRule::conditions is non-null ([\matrix-org#2217](matrix-org#2217)). * Make createThread more resilient when missing rootEvent ([\matrix-org#2207](matrix-org#2207)). Fixes element-hq/element-web#21130. * Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2201](matrix-org#2201)). Fixes element-hq/element-web#21170. * fix relation sender filter ([\matrix-org#2196](matrix-org#2196)). Fixes element-hq/element-web#20877. * Fix bug with one-way audio after a transfer ([\matrix-org#2193](matrix-org#2193)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what your changelog entry will look like:
🐛 Bug Fixes