Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage around push rules with no conditions #2219

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 4, 2022

Add tests for #2217


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Mar 4, 2022
@t3chguy t3chguy requested a review from a team as a code owner March 4, 2022 13:38
@codecov-commenter
Copy link

Codecov Report

Merging #2219 (79f32d1) into develop (9e4f109) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2219   +/-   ##
========================================
  Coverage    57.61%   57.61%           
========================================
  Files           90       90           
  Lines        16270    16270           
  Branches      3743     3743           
========================================
  Hits          9374     9374           
  Misses        6896     6896           

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks.

@andybalaam
Copy link
Member

Really?
image

@t3chguy
Copy link
Member Author

t3chguy commented Mar 4, 2022

@andybalaam probably because of how the coverage is gathered, the ?. won't be distinct from . so doesn't improve coverage because the same if branch is being hit. Another test must already be hitting the [] case, so the null case won't improve coverage.

@t3chguy t3chguy merged commit 70efed1 into develop Mar 4, 2022
@t3chguy t3chguy deleted the t3chguy/fix/21305 branch March 4, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants