Send and handle stable name for withheld codes #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since MSC2399 is finished FCP and it's in the spec, we can use the stable name now
Codecov Report
@@ Coverage Diff @@
## develop #2232 +/- ##
===========================================
+ Coverage 57.82% 57.87% +0.04%
===========================================
Files 90 90
Lines 16298 16300 +2
Branches 3754 3755 +1
===========================================
+ Hits 9425 9434 +9
+ Misses 6873 6866 -7
|
turt2live
approved these changes
Mar 11, 2022
Comment on lines
-3118
to
+3119
| } else if (event.getType() === "org.matrix.room_key.withheld") { | ||
| } else if (event.getType() === "m.room_key.withheld" | ||
| || event.getType() === "org.matrix.room_key.withheld") { |
There was a problem hiding this comment.
These sorts of checks get easier with a NamespacedValue, but considering it'd be 1 line of code to help 2 other lines, the value is questionable.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MSC2399 is finished FCP and it's in the spec, we can use the stable name now.
This change is marked as an internal change (Task), so will not be included in the changelog.