Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of MSC3824 to add action= param on SSO login #2398

Merged
merged 16 commits into from
Sep 11, 2022

Conversation

hughns
Copy link
Member

@hughns hughns commented May 24, 2022


Here's what your changelog entry will look like:

✨ Features

@hughns hughns marked this pull request as ready for review August 4, 2022 18:16
@hughns hughns requested a review from a team as a code owner August 4, 2022 18:16
src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hughns can you add a test for it?

@hughns
Copy link
Member Author

hughns commented Sep 1, 2022

@hughns can you add a test for it?

I've added some some simple test cases.

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hughns hughns enabled auto-merge (squash) September 11, 2022 21:08
@hughns hughns merged commit a57c430 into develop Sep 11, 2022
@hughns hughns deleted the hughns/msc3824-sso-action branch September 11, 2022 21:18
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Sep 28, 2022
* Add a property aggregating all names of a NamespacedValue ([\matrix-org#2656](matrix-org#2656)).
* Implementation of MSC3824 to add action= param on SSO login ([\matrix-org#2398](matrix-org#2398)). Contributed by @hughns.
* Add invited_count and joined_count to sliding sync room responses. ([\matrix-org#2628](matrix-org#2628)).
* Base support for MSC3847: Ignore invites with policy rooms ([\matrix-org#2626](matrix-org#2626)). Contributed by @Yoric.
* Fix handling of remote echoes doubling up ([\matrix-org#2639](matrix-org#2639)). Fixes matrix-org#2618.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants