Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The request callback provided by bootstrapCrossSigning is async #2431

Merged
merged 1 commit into from
Jun 3, 2022
Merged

The request callback provided by bootstrapCrossSigning is async #2431

merged 1 commit into from
Jun 3, 2022

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Jun 2, 2022 •
edited by github-actions bot
Loading

Typing minutiae to accompany matrix-org/matrix-react-sdk#8750.

This change is marked as an internal change (Task), so will not be included in the changelog.

@duxovni duxovni added the T-Task Tasks for the team like planning label Jun 2, 2022
@duxovni duxovni requested a review from a team as a code owner June 2, 2022 19:04
robintown
robintown approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scary that TS didn't catch that automatically

@duxovni duxovni merged commit e35ede0 into develop Jun 3, 2022
@duxovni duxovni deleted the fayed/bootstrap-cross-signing-async branch June 3, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duxovni @robintown