Fix mark as unread button #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
reviewed
May 22, 2023
richvdh
reviewed
May 22, 2023
richvdh
requested changes
May 22, 2023
spec/unit/room.spec.ts
Outdated
Comment on lines
177
to
182
| const { rootEvent, thread } = mkThread({ | ||
| room, | ||
| client: new TestClient().client, | ||
| authorId: "@bob:example.org", | ||
| participantUserIds: ["@bob:example.org"], | ||
| }); |
There was a problem hiding this comment.
It seems to me that adding this here means that we are no longer testing the behaviour when there are no thread events? Or is that tested somewhere else?
I'm unclear what exactly addRoomMainAndThreadMessages is supposed to do, and what the semantics of tsMain and tsThread are supposed to do. Given the fact that we need to change this, I'm evidently not alone.
Please could you give the function a proper doc comment describing what it does, and what tsMain and tsThread do.
There was a problem hiding this comment.
@richvdh take a look at the last commit. I threw away the magic setup function. It should (hopefully) be clearer now.
richvdh
reviewed
May 23, 2023
richvdh
approved these changes
May 23, 2023
weeman1337
added
the
backport staging
RiotRobot
pushed a commit
that referenced
this pull request
May 24, 2023
* Fix mark as unread button * Revert to prefer the last event from the main timeline * Refactor room test * Fix type * Improve docs * Insert events to the end of the timeline * Improve test doc (cherry picked from commit 063d69e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes element-hq/element-web#25411
PSF-2018
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.